Ayal Baron has posted comments on this change.
Change subject: gluster: move exportToSupervdsm at module level
......................................................................
Patch Set 11: (1 inline comment)
....................................................
File vdsm/gluster/__init__.py
Line 22:
Line 23: MODULE_LIST = ('cli',)
Line 24:
Line 25:
Line 26: def exportToSuperVdsm(func):
you're exporting functions but you're specifically stating the name of the user
(supervdsm) instead of a more generic function name that doesn't imply a
specific usage.
Line 27: @wraps(func)
Line 28: def wrapper(*args, **kwargs):
Line 29: return func(*args, **kwargs)
Line 30:
--
To view, visit http://gerrit.ovirt.org/13051
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b8217899a637a10c7bc47a13e8afdddc1b0fefe
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Aravinda VK <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
