Ayal Baron has posted comments on this change.
Change subject: Stop spm if refresh fail on bad parameters.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/storage/hsm.py
Line 788: se.StoragePoolActionError(
Line 789: "spUUID=%s, msdUUID=%s, masterVersion=%s" %
Line 790: (spUUID, msdUUID, masterVersion)))
Line 791: self.getPool(spUUID) # Validate that is the correct pool.
Line 792: vars.task.getExclusiveLock(STORAGE, spUUID)
this change is very problematic as it will serialize this op with others and
fail on timeout.
What cannot run concurrently and why?
Line 793: pool = self.getPool(spUUID)
Line 794: try:
Line 795: self.validateSdUUID(msdUUID)
Line 796: pool.refresh(msdUUID, masterVersion)
Line 796: pool.refresh(msdUUID, masterVersion)
Line 797: except (se.StorageDomainAccessError,
se.StorageDomainDoesNotExist,
Line 798: se.StoragePoolWrongMaster):
Line 799: self.log.error("refreshStoragePool failed", exc_info=True)
Line 800: pool.stopSpm()
who said this host is spm?
Line 801: self._disconnectPool(pool, pool.id, pool.scsiKey, False)
Line 802: raise
Line 803:
Line 804: if pool.hsmMailer:
--
To view, visit http://gerrit.ovirt.org/13930
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f85c3e731551b6974483cffe38c7ac37281370b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Daniel Paikov <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
