Ayal Baron has posted comments on this change.
Change subject: Remove force parameter in StoragePool.spmStop()
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/sp.py
Line 393: cls.log.debug("master `%s` is not mounted, skipping",
master)
Line 394:
Line 395: def stopSpm(self):
Line 396: with self.lock:
Line 397: if self.spmRole == SPM_FREE:
this changes the semantics. Since this is an spm operation, if I'm not spm
when this method is called then this will throw an exception.
If I'm under the clustered lock however and pass securityoverride then it's
feasible that this if will evaluate to true even though we need to cleanup.
In any event, if you're removing force, you need to remove this if.
Line 398: return True
Line 399:
Line 400: self._shutDownUpgrade()
Line 401: self._setUnsafe()
--
To view, visit http://gerrit.ovirt.org/13929
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7eaf8883e62a72445e27f0bc9876fe61a10bcb3f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Daniel Paikov <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
