Dan Kenigsberg has posted comments on this change.
Change subject: libvirtvm: avoid concurrent VM changes during saveState
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 1278: self._lastXMLDesc = '<domain><uuid>%s</uuid></domain>' %
self.id
Line 1279: self._devXmlHash = '0'
Line 1280: self._released = False
Line 1281: self._releaseLock = threading.Lock()
Line 1282: self._stateChangeLock = threading.Lock()
Shouldn't you protect vm.py's calls to saveState, too?
As much as I hate RLock, it may be safer to take one within saveState() itself.
Regarding naming: "state" is a vague concept (yes, I dislike the name
saveState, too). wouldn't "_confLock" be clearer?
Line 1283: self.saveState()
Line 1284: self._watchdogEvent = {}
Line 1285:
Line 1286: def _buildLease(self, domainID, volumeID, leasePath,
leaseOffset):
--
To view, visit http://gerrit.ovirt.org/13624
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic08b4073f5e3f5184baa5f1c7dd3ec5a148ff60b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dafna Ron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
