Yaniv Bronhaim has posted comments on this change. Change subject: Check supervdsm execution return code ......................................................................
Patch Set 1: (1 inline comment) .................................................... File tests/superVdsmTests.py Line 32: str(os.getuid())] Line 33: p = misc.execCmd(superVdsmCmd, sync=False, sudo=True) Line 34: p.wait(2) Line 35: if p.returncode: Line 36: raise AssertionError('failed to start supervdsm') Agree about mocking the cmd, next modification of supervdsm I'll add it. Line 37: Line 38: Line 39: class TestSuperVdsm(TestCaseBase): Line 40: def setUp(self): -- To view, visit http://gerrit.ovirt.org/14428 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b15efaabd2e45eb2f752d9f2ad73400033f2983 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches