Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Use UUID as unique identifier for socket names ......................................................................
Patch Set 5: I would prefer that you didn't submit this (2 inline comments) Sorry Vinzenz for not noticing these two issues on the former round. .................................................... File vdsm/libvirtvm.py Line 36: import hooks Line 37: import caps Line 38: from vdsm import netinfo Line 39: import supervdsm Line 40: import os Not: import from stdlib first. Line 41: Line 42: _VMCHANNEL_DEVICE_NAME = 'com.redhat.rhevm.vdsm' Line 43: # This device name is used as default both in the qemu-guest-agent Line 44: # service/daemon and in libvirtd (to be used with the quiesce flag). Line 1390: socketPath = self._makeChannelPath(name) Line 1391: if path != socketPath: Line 1392: os.symlink(path, socketPath) Line 1393: Line 1394: except IndexError: Could you make this big try-block smaller? Around the relevant index lookup only? Line 1395: pass Line 1396: Line 1397: def _domDependentInit(self): Line 1398: if self.destroyed: -- To view, visit http://gerrit.ovirt.org/13220 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f12a6b5ac641686ad29dc17a9f214ee82b3b2cf Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
