Daniel Erez has posted comments on this change. Change subject: introducing virtio-scsi support ......................................................................
Patch Set 1: (3 inline comments) .................................................... Commit Message Line 19: - test virtio-scsi image disk Line 20: - test virtio-scsi LUN passthrough Line 21: Line 22: [1] 'sgio': SCSI Generic IO - filtered/unfiltered Line 23: (indicates whether the kernel will filter unprivileged It should be supported in F17: http://fedoraproject.org/wiki/Features/virtio-scsi Line 24: SG_IO commands for the disk). Line 25: Line 26: Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 .................................................... File vdsm/libvirtvm.py Line 1155: diskelem.appendChildWithArgs('serial', text=self.serial) Line 1156: if hasattr(self, 'bootOrder'): Line 1157: diskelem.appendChildWithArgs('boot', order=self.bootOrder) Line 1158: Line 1159: if self.device == 'disk' or self.device == 'lun': Do you mean for 'lun' device or 'sgio' attribute? Line 1160: driverAttrs = {'name': 'qemu'} Line 1161: if self.blockDev: Line 1162: driverAttrs['io'] = 'native' Line 1163: else: Line 3015: # Get disk address Line 3016: address = self._getUnderlyingDeviceAddress(x) Line 3017: Line 3018: # Get sgio value (filtered/unfiltered) Line 3019: sgio = x.getAttribute('sgio') You're right. I'll remove it. Line 3020: Line 3021: for d in self._devices[vm.DISK_DEVICES]: Line 3022: if d.path == devPath: Line 3023: d.name = name -- To view, visit http://gerrit.ovirt.org/14681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If624064269328253dbc3cb32a72e20f01cdb0958 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
