Dan Kenigsberg has submitted this change and it was merged. Change subject: Test: regression test to catch cross imports. ......................................................................
Test: regression test to catch cross imports. This test is useful to catch non legal imports in lib/vdsm. Lib modules cannot use/depend upon regular (non python package vdsm) modules: for example lib/vdscli.py can't depend on vdsm/guestIF.py module. This test updates the PYTHONPATH by removing the regular vdsm modules, later it tries to import lib modules, if there are non legal imports an ImportError is raised. The error message reports the traceback showing the non legal import. Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Signed-off-by: Giuseppe Vallarelli <[email protected]> --- M .gitignore M tests/Makefile.am A tests/crossImportsTests.py.in 3 files changed, 77 insertions(+), 0 deletions(-) Approvals: Giuseppe Vallarelli: Verified Antoni Segura Puimedon: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46b293c34e5968d21097137f3d1076f4199a5fd7 Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
