Antoni Segura Puimedon has posted comments on this change. Change subject: Extract helper functions to update nic and bonding's mtu ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vdsm/netconf/ifcfg.py Line 690: if currmtu and newmtu != currmtu: Line 691: if bonding: Line 692: self.setBondingMtu(bonding, newmtu) Line 693: else: Line 694: self.setIfaceMtu(nics[0], newmtu) @Giuseppe: If no bonding, then nics = [nic] and that is why he does nics[0]. That is perfectly fine. Line 695: Line 696: Line 697: def ifdown(iface): Line 698: "Bring down an interface" -- To view, visit http://gerrit.ovirt.org/14871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic82b1d9a27492619548f1c7ba3fced79ee68a1a8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches