Yaniv Bronhaim has posted comments on this change. Change subject: [WIP] Improving vdsm-tool commands - retrieving host uuid by utils.getHostUUID ......................................................................
Patch Set 4: (2 inline comments) .................................................... File lib/vdsm/utils.py Line 644 Line 645 Line 646 Line 647 Line 648 you wrote it... I didn't want to modify more than adding the legacy parm in this path , but alright. I'll fix it .................................................... File vdsm/caps.py Line 290: except: Line 291: logging.debug('not reporting hooks', exc_info=True) Line 292: Line 293: caps['operatingSystem'] = osversion() Line 294: caps['uuid'] = utils.getHostUUID(legacy=False) not sure.. but where we use the old uuid we should also return the old one when calling 'vdsm-tool vdsm-id'. how do we keep that? Line 295: caps['packages2'] = _getKeyPackages() Line 296: caps['emulatedMachines'] = _getEmulatedMachines() Line 297: caps['ISCSIInitiatorName'] = _getIscsiIniName() Line 298: caps['HBAInventory'] = storage.hba.HBAInventory() -- To view, visit http://gerrit.ovirt.org/14866 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8cab7f55697e07479a4f35c161bd836925374e8 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches