Mark Wu has posted comments on this change.
Change subject: Move getMaxMtu to netinfo
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
Just one minor issue inline.
....................................................
File lib/vdsm/netinfo.py
Line 130: mtu = file('/sys/class/net/%s/mtu' % iface).readline().rstrip()
Line 131: return mtu
Line 132:
Line 133:
Line 134: def getMaxMtu(nics, mtu):
I suggest we make the name of parameters more general. because we also could
get maximum mtu among vlans sitting on the same bond/nic or removing network.
Line 135: """
Line 136: Get the max MTU value from configuration/parameter
Line 137:
Line 138: :param nics: list of nics
--
To view, visit http://gerrit.ovirt.org/14856
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib994deab0d38661508dd6cc4c890a340000617ac
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
