Giuseppe Vallarelli has posted comments on this change. Change subject: NetReload: netmodels for delNetwork ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vdsm/netconf/ifcfg.py Line 179: self.configWriter.removeIpConfig(iface.name) Line 180: if not hasattr(iface, 'destroyOnRemove'): Line 181: ifup(iface.name) Line 182: Line 183: def removeBond(self, bonding): removeBond and removeNic are not useful, why not using directly removeIface? Line 184: self.removeIface(bonding) Line 185: Line 186: def removeNic(self, nic): Line 187: self.removeIface(nic) -- To view, visit http://gerrit.ovirt.org/14873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e11fd923a4f5d07d069193278f3eadc94f327ec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
