Dan Kenigsberg has submitted this change and it was merged. Change subject: Deactivate libvirtVM.Drives() ......................................................................
Deactivate libvirtVM.Drives() Change I8d310f216987b7 has introduced teardownVolumePath() calls with a Drive object instead of a drive dictionary from self.conf. In its previous form, teardownVolumePath() has silently ignored such input, keeping the volume active. This patch makes teardownVolumePath() handle such inputs properly. This is one baby step in the process of getting rid of self.conf: we would like to use the objects everywhere within vdsm. Note that this patch introduces an ugly log line when pointlessly trying to tear down a cdrom device. This would be fixed in a subsequent patch. Change-Id: I8ba965f0987037fa5dafc6b3ea6eeb6f01a82436 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=962549 Signed-off-by: Eduardo <ewars...@redhat.com> Signed-off-by: Dan Kenigsberg <dan...@redhat.com> --- M vdsm/clientIF.py M vdsm/libvirtvm.py 2 files changed, 18 insertions(+), 7 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14869 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ba965f0987037fa5dafc6b3ea6eeb6f01a82436 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Daniel Paikov <pai...@gmail.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Lee Yarwood <lyarw...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Peter V. Saveliev <p...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
