Antoni Segura Puimedon has posted comments on this change. Change subject: Add a backward reference their master device for Vlan, Bond and Nic ......................................................................
Patch Set 1: (2 inline comments) .................................................... File vdsm/netmodels.py Line 115: self.name = name Line 116: self.ip = ipconfig Line 117: self.mtu = mtu Line 118: self.state = state Line 119: for port in ports: This will fail if a Bridge is created without ports. I will change my netmodels patch so that the default parameter for ports is not None but (). This way no check will be needed here nor in the configurators, just iteration. Line 120: port.setMaster(self) Line 121: self.ports = ports Line 122: self.forwardDelay = forwardDelay Line 123: self.stp = stp Line 155: self.configurator = configurator Line 156: self.mtu = mtu Line 157: self.ip = ipconfig Line 158: self.master = None Line 159: if slaves: See comment to line 119. Line 160: for slave in slaves: Line 161: slave.setMaster(self) Line 162: self.slaves = slaves Line 163: else: -- To view, visit http://gerrit.ovirt.org/14870 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba8958549a301c9faac70a32cbafdf320128c85a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
