Dan Kenigsberg has submitted this change and it was merged. Change subject: Allow modification of disk xml by before_disk_hotplug ......................................................................
Allow modification of disk xml by before_disk_hotplug The return value of hooks.before_disk_hotplug wasn't being used like it is in hooks.before_nic_hotplug. Meaning that if a hook changed the disk XML it wasn't actually updated in the VM's domxml. Change-Id: I0b1cf81c696f68fbdb67a5a41a54f8f055c5b73b Signed-off-by: Assaf Muller <[email protected]> --- M vdsm/libvirtvm.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/13803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b1cf81c696f68fbdb67a5a41a54f8f055c5b73b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
