Dan Kenigsberg has posted comments on this change.
Change subject: clientIF: Check image alignment using virt-alignment-scan
......................................................................
Patch Set 8: (1 inline comment)
....................................................
File vdsm/clientIF.py
Line 363: volPath = self.prepareVolumePath(drive)
Line 364: try:
Line 365: out = alignmentScan.scanImage(volPath)
Line 366: except alignmentScan.VirtAlignError as e:
Line 367: self.log.warning("Error in virt-alignment-scan: %s", e)
I still do not see why this condition should be considered as a success of the
verb.
Line 368: else:
Line 369: for line in out:
Line 370: aligning[line.partitionName] =
line.alignmentScanResult
Line 371: finally:
--
To view, visit http://gerrit.ovirt.org/12003
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia925f5f138948acca623f6379b7b811474a43ffe
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykap...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
