Antoni Segura Puimedon has posted comments on this change. Change subject: tests: Adding functional tests for networking ......................................................................
Patch Set 8: (2 inline comments) .................................................... File tests/functional/networkTests.py Line 36: self.vdsm_net = VdsProxy() Line 37: Line 38: def testAddDeleteANetwork(self): Line 39: status, msg = self.vdsm_net.addNetwork(NETWORK_NAME) Line 40: self.assertEqual(status, SUCCESS, msg) I am of the opinion that we should make a context manager that would give you resources (like a dummy created via (ip link add <dt_randchars till 15> type dummy) and would clean them up after the test. Probably the same applies to bonds. If we use predictable names jenkins won't be able to run jobs in parallel that test networking. Line 41: self.assertTrue(self.vdsm_net.networkExists(NETWORK_NAME)) Line 42: Line 43: status, msg = self.vdsm_net.delNetwork(NETWORK_NAME) Line 44: self.assertEqual(status, SUCCESS, msg) .................................................... File tests/functional/utils.py Line 16: # Line 17: # Refer to the README and COPYING files for full details of the license Line 18: # Line 19: from vdsm import netinfo Line 20: from vdsm import vdscli For me it would make sense for stuff that is used by several functional tests not just networking stuff. Line 21: Line 22: Line 23: SUCCESS = 0 Line 24: -- To view, visit http://gerrit.ovirt.org/14840 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3be71db9dc0b92c443b87e22fe06f920055c4d3 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
