Saggi Mizrahi has posted comments on this change.
Change subject: getAllTasksList\Status with spUUID retrieves info only if host
is the SPM
......................................................................
Patch Set 15: I would prefer that you didn't submit this
(4 inline comments)
....................................................
File client/vdsClient.py
Line 1159: return 0, ''
Line 1160:
Line 1161: def getAllTasksInfo(self, args):
Line 1162: if len(args) > 0:
Line 1163: status = self.s.getAllTasksInfo(args[0])
self.s.getAllTasksInfo(*args) and remove the condition
Line 1164: else:
Line 1165: status = self.s.getAllTasksInfo()
Line 1166: if status['status']['code']:
Line 1167: return status['status']['code'],
status['status']['message']
....................................................
File vdsm_api/vdsmapi-schema.json
Line 337: # @Host.getAllTasksInfo:
Line 338: #
Line 339: # Get extra information about all tasks.
Line 340: #
Line 341: # @spUUID: #optional If specified returns pool specific tasks.
Otherwise will
And returns an error if not spm
Line 342: # return all currently visible tasks.
Line 343: #
Line 344: # Returns:
Line 345: # A mapping of Task information
....................................................
File vdsm/storage/hsm.py
Line 2051: # SPM status changes (HSM tasks or empty task list after
cleaning SPM
Line 2052: # info)
Line 2053: # To reduce the race we validate SPM status before and after
retreiving
Line 2054: # the task list.
Line 2055: if spUUID:
Don't check before
Line 2056: self.validateSPM(spUUID)
Line 2057: allTasksStatus = self.taskMng.getAllTasksStatuses("spm")
Line 2058: if spUUID:
Line 2059: self.validateSPM(spUUID)
Line 2054: # the task list.
Line 2055: if spUUID:
Line 2056: self.validateSPM(spUUID)
Line 2057: allTasksStatus = self.taskMng.getAllTasksStatuses("spm")
Line 2058: if spUUID:
Only check if allTasksStatus is empty
Line 2059: self.validateSPM(spUUID)
Line 2060: return dict(allTasksStatus=allTasksStatus)
Line 2061:
Line 2062: @public
--
To view, visit http://gerrit.ovirt.org/12517
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cbc11c924f0bd078749fea26d79b39c0dd48094
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Daniel P. Berrange <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
