Giuseppe Vallarelli has posted comments on this change. Change subject: NetReload: netmodels for addNetwork ......................................................................
Patch Set 7: No score (1 inline comment) .................................................... File vdsm/configNetwork.py Line 175: if bonding not in vlanedIfaces: Line 176: for nic in nics: Line 177: if nic not in vlanedIfaces: Line 178: ifdown(nic) Line 179: netEnt.configure(network=network, **options) What about a general Network model with 2 methods, addNetDevice and configure which call configure on the list of netDevices created by adding them with addNetDevice ? In this way you can also move the configure methods to the respective entities. Line 180: Line 181: Line 182: def assertBridgeClean(bridge, vlan, bonding, nics): Line 183: ports = set(netinfo.ports(bridge)) -- To view, visit http://gerrit.ovirt.org/14303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
