Yaniv Bronhaim has posted comments on this change.
Change subject: Extend vdsm.tool.service to cover alternative service names
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
Please split to 2 patches, one that adds the alternative names and one that
adds the initctlNative and sysvNative decorators.
....................................................
File lib/vdsm/tool/service.py
Line 57: "/usr/sbin/update-rc.d",
Line 58: )
Line 59:
Line 60: _srvNameAlts = {
Line 61: 'iscsid': ['iscsid', 'open-iscsi'],
tuples ?
Line 62: 'libvirtd': ['libvirtd', 'libvirt-bin'],
Line 63: 'multipathd': ['multipathd', 'multipath-tools'],
Line 64: 'network': ['network', 'networking'],
Line 65: }
--
To view, visit http://gerrit.ovirt.org/14720
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5308c9db0399dbe9c4f0d6308943307e51d3d447
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
