Mark Wu has posted comments on this change.
Change subject: Separate adding libvirt network from configuring host network.
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/netconf/ifcfg.py
Line 109: ifup(nic.name, bootproto == 'dhcp' and
Line 110: not utils.tobool(opts.get('blockingdhcp')))
Line 111:
Line 112: def configureLibvirtNetwork(self, network, bridged, iface):
Line 113: self.configWriter.createLibvirtNetwork(network, True, iface)
should use 'bridged' instead of 'True'.
My fault. I apologize for it!
Line 114: self._libvirtAdded.add(network)
Line 115:
Line 116: def configureBonding(self, bond, nics, bridge=None, mtu=None,
Line 117: bondingOptions=None):
--
To view, visit http://gerrit.ovirt.org/14880
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bb352ac7c298baa4a3e4a5cba7d23b0b033952f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
