Antoni Segura Puimedon has posted comments on this change. Change subject: NetReload: netmodels for addNetwork ......................................................................
Patch Set 10: (1 inline comment) .................................................... File vdsm/configNetwork.py Line 73: except ValueError: Line 74: raise ConfigNetworkError(ne.ERR_BAD_BONDING, 'Multiple nics ' Line 75: 'require a bonding device') Line 76: else: Line 77: bond = _netinfo.getBondingForNic(nic) Lines 77-80 should be moved to Nic.objectivize after patch http://gerrit.ovirt.org/#/c/14870/ that adds a reference to a master device and will make this check belong there. Line 78: if bond: Line 79: raise ConfigNetworkError(ne.ERR_USED_NIC, 'nic %s already ' Line 80: 'enslaved to %s' % (nic, bond)) Line 81: topObj = Nic.objectivize(nic, configurator, mtu, _netinfo) -- To view, visit http://gerrit.ovirt.org/14303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
