Dan Kenigsberg has posted comments on this change. Change subject: Supervdsm as external service ......................................................................
Patch Set 15: I would prefer that you didn't submit this (2 inline comments) minor comments about the functional test. .................................................... File tests/functional/supervdsmFuncTests.py Line 20: import supervdsm Line 21: import logging Line 22: from supervdsmServer import LOG_CONF_PATH Line 23: Line 24: logging.config.fileConfig(LOG_CONF_PATH) why is this import needed here? Line 25: Line 26: Line 27: class TestSuperVdsmRemotly(TestCaseBase): Line 28: def setUp(self): Line 25: Line 26: Line 27: class TestSuperVdsmRemotly(TestCaseBase): Line 28: def setUp(self): Line 29: self._proxy = supervdsm.getProxy() I suspect that this test is expected to fail if run as non-vdsm user. You should probably skip the test in such a case. Line 30: Line 31: def tearDown(self): Line 32: self._proxy = None Line 33: -- To view, visit http://gerrit.ovirt.org/11051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I290a584f38129406cd390fdd1d3d1aad9f829a60 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Adam Litke <a...@us.ibm.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Mei Liu <liu...@linux.vnet.ibm.com> Gerrit-Reviewer: Ohad Basan <oba...@redhat.com> Gerrit-Reviewer: Royce Lv <lvro...@linux.vnet.ibm.com> Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
