Dan Kenigsberg has posted comments on this change.
Change subject: Creating /var/run/vdsm directory as part of rpm installation
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm.spec.in
Line 585: /usr/sbin/usermod -a -G %{qemu_group},%{snlk_group} %{vdsm_user}
Line 586: /usr/sbin/usermod -a -G %{qemu_group},%{vdsm_group} %{snlk_user}
Line 587:
Line 588: %post
Line 589: /bin/mkdir -p %{_localstatedir}/run/%{vdsm_name}
we already create it, in Makefile (as we should)
$(MKDIR_P) $(DESTDIR)$(vdsmrundir)
all we should do, I believe is change
%ghost %dir %{_localstatedir}/run/%{vdsm_name}
to %dir.
Line 590: %{_bindir}/vdsm-tool sebool-config || :
Line 591: # set the vdsm "secret" password for libvirt
Line 592: %{_bindir}/vdsm-tool set-saslpasswd
Line 593:
--
To view, visit http://gerrit.ovirt.org/15170
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If615e8c9f0a9031f8b18c768e63491f3e434c01f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
