Yaniv Bronhaim has posted comments on this change.
Change subject: java_bindings: Add function overloads
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
also, fix tabs of course..
....................................................
File
client/java/vdsm-json-rpc/src/main/java/org/ovirt/vdsm/jsonrpc/JsonRpcClient.java
Line 159: public Future<JsonRpcResponse> call(JsonRpcRequest req) {
Line 160: final JsonNode json = req.toJson();
Line 161: final ByteArrayOutputStream os = new
ByteArrayOutputStream();
Line 162: try {
Line 163: try (JsonGenerator gen =
_jfactory.createJsonGenerator(os)) {
this is java7 feature.. keep in mind that downstream we still use java6
Line 164: gen.writeTree(json);
Line 165: }
Line 166: } catch (IOException e) {
Line 167: // Never happens
--
To view, visit http://gerrit.ovirt.org/14823
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I40887a5fd2e3901efdcc9633c5858ae6b2445291
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Adam Litke <a...@us.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
