Adam Litke has posted comments on this change.
Change subject: gluster: verbs for managing services
......................................................................
Patch Set 18: I would prefer that you didn't submit this
(1 inline comment)
One small change to make it correct. You can test your schema file for
validity with the following command:
./vdsm_api/process-schema.py vdsm/gluster/vdsmapi-gluster-schema.json out.html
....................................................
File vdsm/gluster/vdsmapi-gluster-schema.json
Line 243: # status information for list of services
Line 244: #
Line 245: # Since: 4.10.3
Line 246: ##
Line 247: {'command': {'class': 'GlusterService', 'name': 'get'},
name needs to be 'manage'
Line 248: 'data': {'serviceName': 'str', 'action': 'GlusterServiceAction',
'failOnError': 'bool'},
--
To view, visit http://gerrit.ovirt.org/11094
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a16bf566d17e186a66503391dfd04b2f2bb4bb4
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK <avish...@redhat.com>
Gerrit-Reviewer: Adam Litke <a...@us.ibm.com>
Gerrit-Reviewer: Aravinda VK <avish...@redhat.com>
Gerrit-Reviewer: Bala.FA <barum...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
