Dan Kenigsberg has posted comments on this change.
Change subject: cpopen: Fix signal handling in sync points
......................................................................
Patch Set 6: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File lib/cpopen/cpopen.c
Line 75: if (rv == 0) { /* EOF */
Line 76: return bread;
Line 77: } else if (rv < 0) { /* ERROR */
Line 78: switch (errno) {
Line 79: case EINTR:
If it were Python, the compiler would have nacked this indentation...
Other than that - I'm fine with this patch; Can anyone verify it?
Line 80: case EAGAIN:
Line 81: break;
Line 82: default:
Line 83: return rv;
--
To view, visit http://gerrit.ovirt.org/15165
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2883091c377c1e4ff9f69b87fc137326b583ab8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
