Yaniv Bronhaim has posted comments on this change. Change subject: Extend vdsm-tool: moving configure libvirt to external shell script ......................................................................
Patch Set 1: (3 inline comments) .................................................... File lib/vdsm/tool/libvirt_configure.sh.in Line 7: # (at your option) any later version. See the files README and Line 8: # LICENSE_GPL_v2 which accompany this distribution. Line 9: # Line 10: Line 11: . @LIBEXECDIR@/ovirt_functions.sh isOvirt is the only function defined in ovirt_functions. do we still use this file? Line 12: GETCONFITEM=@VDSMDIR@/get-conf-item Line 13: CONF_FILE=@CONFDIR@/vdsm.conf Line 14: LCONF=/etc/libvirt/libvirtd.conf Line 15: QCONF=/etc/libvirt/qemu.conf Line 91: local start_conf_section="## beginning of configuration section ${by_vdsm}" Line 92: local end_conf_section="## end of configuration section ${by_vdsm}" Line 93: local ts=/etc/pki/vdsm Line 94: Line 95: if isOvirt couldn't find the differences between ovirt and rhev about this part, ovirt_store_config is not defined in ovirt-functions anymore, and the modification of the conf files is done by set_if_default. I remove this part Line 96: then Line 97: . /usr/libexec/ovirt-functions Line 98: else Line 99: ovirt_store_config() { :; } Line 108: qconf="$3" Line 109: ldconf="$4" Line 110: qlconf="$5" Line 111: Line 112: # do not configure ovirt nodes before registration shouldn't this part required both for ovirt node and rhev? .. leave it for now until investigating it Line 113: if isOvirt Line 114: then Line 115: if [ ! -f /etc/pki/vdsm/certs/vdsmcert.pem ] Line 116: then -- To view, visit http://gerrit.ovirt.org/15216 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id58b129afbf141a47a85b421961bf5b1776b41e4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches