Mark Wu has posted comments on this change.
Change subject: mom: add mom balloon functional tests for running vms
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(2 inline comments)
Just minor issues
....................................................
File tests/functional/momTests.py
Line 36: raise SkipTest('MOM is not installed')
Line 37:
Line 38:
Line 39: class MOMTest(TestCaseBase):
Line 40: BalloonRatio = namedtuple('BalloonRatio', 'target, low, high')
it seems 'target' is a little bit confusing. actually, here it represents the
initial value which the tuning starts from. So please change it to convey this
meaning.
Line 41:
Line 42: def setUp(self):
Line 43: self.s = vdscli.connect()
Line 44:
Line 138:
Line 139: # Define the target, low and high value of shrink and grow
operation.
Line 140: # Target is the 'balloon_cur' value before the operation
performed.
Line 141: # (low, high) is the proper range for 'balloon_cur' after the
Line 142: # operation.
you'd better to explain the why ratio values is defined as following.
Line 143: self.shrinkRatio = self.BalloonRatio(1, 0.9, 0.9025)
Line 144: self.growRatio = self.BalloonRatio(0.9, 0.99225, 1)
Line 145:
Line 146: vmsOldStats = self._prepare(operation, r['statsList'])
--
To view, visit http://gerrit.ovirt.org/13156
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I922568233dc769d83e2fdffe1c24439d13d03d7e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mei Liu <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Mei Liu <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
