Giuseppe Vallarelli has posted comments on this change. Change subject: Simplify setNewMtu() ......................................................................
Patch Set 3: (1 inline comment) .................................................... File vdsm/netconf/ifcfg.py Line 172: if bridge.port: Line 173: bridge.port.remove() Line 174: Line 175: def removeVlan(self, vlan): Line 176: vlan.mtu = netinfo.getMtu(vlan.name) Mark, why do we need to set the vlan mtu, before removing it? Line 177: ifdown(vlan.name) Line 178: self.configWriter.removeVlan(vlan.name) Line 179: vlan.device.remove() Line 180: -- To view, visit http://gerrit.ovirt.org/15355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32e8e0d45b7887af8fd1b003fd4c358826b77289 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches