Antoni Segura Puimedon has posted comments on this change. Change subject: tests: Adding functional tests for networking ......................................................................
Patch Set 13: (2 inline comments) Some minor comments. .................................................... File tests/functional/networkTests.py Line 26: Line 27: Line 28: NETWORK_NAME = 'test-network' Line 29: VLAN_ID = '27' Line 30: BONDING_NAME = 'bond0' I'd probably use a bond that is not present on the system, to avoid, if possible, messing with existing stuff. Line 31: Line 32: Line 33: def setupModule(): Line 34: """Persists network configuration.""" .................................................... File tests/testValidation.py Line 1: # You should extend this to 2013. Line 2: # Copyright 2009-2011 Red Hat, Inc. Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by -- To view, visit http://gerrit.ovirt.org/14840 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3be71db9dc0b92c443b87e22fe06f920055c4d3 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
