Antoni Segura Puimedon has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg ......................................................................
Patch Set 4: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/netconf/libvirtCfg.py Line 22: from vdsm import libvirtconnection Line 23: from vdsm import netinfo Line 24: Line 25: Line 26: class LibvirtCfg(object): being that all the methods are static (defined ass class methods but not using any class information, I'd very much rather remove this class and just have them as module methods. Line 27: Line 28: @classmethod Line 29: def getNetworkDef(cls, network): Line 30: netName = netinfo.LIBVIRT_NET_PREFIX + network -- To view, visit http://gerrit.ovirt.org/15178 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I798cca309f54c3497b18d83de4ff378f0bb6582b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
