Ayal Baron has posted comments on this change.
Change subject: WIP: storage: Introduce exportImageAsNBD vdsm verb
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File vdsm/storage/volume.py
Line 959: # For now, return the entire volume as part of changed info
Line 960: size = int(self.getMetaParam(SIZE))
Line 961: changedArea = [dict(startOffset=0, length=size)]
Line 962:
Line 963: changes = {'startOffset': 0, 'length': size,
This sounds like a generator function would avoid the need to remember where
you dropped off.
Also, it still looks like duplicate info to me, there are 2 levels here:
1. changes "startOffset" and "length" - this is breaking the disk up into chunks
2. for each such chunk you have the changed areas in the changedArea dict
I don't see why we need these 2 levels. The second one is sufficient (each
iteration would still give just a subset of the areas).
Line 964: 'changedArea': changedArea}
Line 965: return changes
Line 966:
Line 967:
--
To view, visit http://gerrit.ovirt.org/14403
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ccacda2b09810a71f445ed65de6a09336ea3fb1
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
