Ayal Baron has posted comments on this change.
Change subject: iscsi: report hba sessions as fiber channel
......................................................................
Patch Set 2: Looks good to me, approved
(1 inline comment)
....................................................
File vdsm/storage/iscsi.py
Line 52: log = logging.getLogger('Storage.ISCSI')
Line 53:
Line 54:
Line 55: def getDevIscsiSessionId(dev):
Line 56: device = os.path.realpath(os.path.join("/sys", "block", dev,
"device"))
can you add a comment with example paths so it's clear why "7:" etc. That way
it would be clear what this function is looking for.
Line 57: if not os.path.exists(device):
Line 58: return None
Line 59: session = os.path.realpath(os.path.join(device, "../.."))
Line 60: return int(os.path.basename(session)[7:])
--
To view, visit http://gerrit.ovirt.org/15161
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b87aafc89a502c872ceec6a55b49d9e49d1ee9f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Derrick Ornelas <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Marina Kalinin <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
