Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: vmChannels: Do not use epoll unregister
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/vmChannels.py
Line 53: self.log.error("Received EPOLLHUP|EPOLLERR on fileno %d",
fileno)
Line 54: if fileno in self._channels:
Line 55: reconnect = True
Line 56: else:
Line 57: self.log.debug("Received EPOLLHUP|EPOLLERR on fd not
handled "
Maybe log the hex of event?
Line 58: "by this class anymore.")
Line 59: elif (event & select.EPOLLIN):
Line 60: obj = self._channels[fileno]
Line 61: obj['reconnects'] = 0
--
To view, visit http://gerrit.ovirt.org/15393
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iacb8dee05e179405d7946bef7329ca406223744a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Gal Hammer <gham...@redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarw...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
