Federico Simoncelli has posted comments on this change. Change subject: volume: add the extendVolumeSize method ......................................................................
Patch Set 3: (1 inline comment) .................................................... File vdsm/storage/blockVolume.py Line 644: def _extendSizeRaw(self, newSize): Line 645: # No sanity checks here, they should be included in the calling Line 646: # function/method. If newSize is smaller than the current size Line 647: # this will lead to data loss. Line 648: newSizeMb = newSize / 2 / 1024 Ah missed this, I'll try to use a constant. Line 649: lvm.extendLV(self.sdUUID, self.volUUID, newSizeMb) Line 650: Line 651: Line 652: def _getVolumeTag(sdUUID, volUUID, tagPrefix): -- To view, visit http://gerrit.ovirt.org/14590 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I817be851d7fbe080adf4da297b526837e244cec6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches