Eduardo has posted comments on this change. Change subject: BZ#836161 - Remove code obsoleted by deleteImage() rewrite. ......................................................................
Patch Set 14: (1 inline comment) .................................................... File vdsm/storage/image.py Line 521: # operation and we can clear all recoveries. Line 522: vars.task.clearRecoveries() Line 523: # If it's 'move' operation, we should delete src image after copying Line 524: if op == MOVE_OP: Line 525: # TODO: Should raise here. You are right. But this is an ancient patch. The MOVE_OP should be removed. Anyway this copyImage function should be in the SD for legacy images. Line 526: try: Line 527: dom = sdCache.produce(srcSdUUID) Line 528: _deleteImage(dom, imgUUID, postZero) Line 529: except se.StorageException: -- To view, visit http://gerrit.ovirt.org/8507 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf01de7dc8bf0a903ebf94d9e33ffad9a195b7de Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Paikov <pai...@gmail.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Elad Ben Aharon <eladba1...@gmail.com> Gerrit-Reviewer: Gadi Ickowicz <gicko...@redhat.com> Gerrit-Reviewer: Haim Ateya <hat...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Shu Ming <shum...@linux.vnet.ibm.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
