Federico Simoncelli has posted comments on this change. Change subject: Storage Domain V3 Functional Tests ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) If it's not too hard let's try to keep testing V1 as well. .................................................... File tests/functional/xmlrpcTests.py Line 274: r['status']['code'], se.StorageDomainDoesNotExist.code) Line 275: Line 276: r = self.s.createStorageDomain( Line 277: storage.sd.name2type(domain['type']), sdid, domain['name'], Line 278: specificArg, storage.sd.name2class(domain['class']), 3) I think this should be a permutation. After all we're still using V1 for ISO/Export domains, we might want to keep testing them too. Line 279: self.assertVdsOK(r) Line 280: undo = lambda sdid=sdid: \ Line 281: self.assertVdsOK(self.s.formatStorageDomain(sdid, True)) Line 282: rollback.prependDefer(undo) -- To view, visit http://gerrit.ovirt.org/14829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf9d918b5ef68eaf75c328a1368d1b8d5198f023 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
