Antoni Segura Puimedon has posted comments on this change.

Change subject: NetReload: netmodels for editBonding/removeBonding
......................................................................


Patch Set 10: (1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 380:             raise ConfigNetworkError(ne.ERR_BAD_NIC,
Line 381:                                      "Unknown nics in: %r" % 
list(nics))
Line 382: 
Line 383: 
Line 384: def _handleBondings(bondings, configurator):
No, I couldn't come up with a better idea. My lame attempt was processBonding, 
so I decided to keep the original.
Line 385:     """ Add/Edit/Remove bond interface """
Line 386:     logger = logging.getLogger("_handleBondings")
Line 387: 
Line 388:     _netinfo = netinfo.NetInfo()


-- 
To view, visit http://gerrit.ovirt.org/15356
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ab6fabb01d38c0e23a950bc5b693fe597b7d21c
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to