Maor Lipchuk has posted comments on this change. Change subject: image: add support to upload/download images ......................................................................
Patch Set 4: (1 inline comment) .................................................... File vdsm/storage/image.py Line 1293: vol = self._activateVolumeForImportExport(domain, imgUUID, volUUID) Line 1294: Line 1295: def sizeCallback(imageSize): Line 1296: # Extend the volume (if relevant) to the image size Line 1297: vol.extend(imageSize / 512) Don't you want to use the constant BLOCK_SIZE here Line 1298: Line 1299: try: Line 1300: volPath = vol.getVolumePath() Line 1301: domain.oop.imageSharing.download(volPath, method, methodArgs) -- To view, visit http://gerrit.ovirt.org/14955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib208bb20d88633167b5c66b42febe912439a022d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
