Alissa Bonas has posted comments on this change. Change subject: constants: unify the BLANK_UUID definition ......................................................................
Patch Set 2: (1 inline comment) How about changing the blank id in BindingXMLRPC to point to the main constant ? Currently there are many references there to other places that mention blank id (such as Volume.BLANK_UUID, Image.BLANK_UUID) - isn't it better to directly work with the one in constants? .................................................... File vdsm/API.py Line 103: Line 104: class VM(APIBase): Line 105: ctorArgs = ['vmID'] Line 106: Line 107: BLANK_UUID = constants.BLANK_UUID Why is there a need to add it here if it wasn't previously declared? Line 108: Line 109: def __init__(self, UUID): Line 110: APIBase.__init__(self) Line 111: self._UUID = UUID -- To view, visit http://gerrit.ovirt.org/15442 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9260d74ae1da1382394a375843b2edff112e6f7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: humble devassy <hchir...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
