Dan Kenigsberg has posted comments on this change. Change subject: Fix the charset conversion logic in hooks.py ......................................................................
Patch Set 3: Looks good to me, but someone else must approve (2 inline comments) .................................................... File vdsm/hooks.py Line 1: import os.path You've fixed this oddity in another file! Line 2: # Line 3: # Copyright 2010-2011 Red Hat, Inc. Line 4: # Line 5: # This program is free software; you can redistribute it and/or modify Line 21: Line 22: from vdsm import utils Line 23: import glob Line 24: import os Line 25: import sys usually, such unrelated cleanups confuse me (and future git-blamers). I prefer having them done in a separate patch. Line 26: import tempfile Line 27: import logging Line 28: Line 29: import hashlib -- To view, visit http://gerrit.ovirt.org/15856 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9063291f8a4a392b2913220fe2839386dcffd825 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
