Giuseppe Vallarelli has posted comments on this change. Change subject: netinfo: fix getMaxMtu generator handling ......................................................................
Patch Set 1: (1 inline comment) .................................................... File lib/vdsm/netinfo.py Line 143: Line 144: getMaxMtu return the highest value in a connection tree, Line 145: it check if a vlan, bond that have a higher mtu value Line 146: """ Line 147: devs_mtu = [getMtu(dev) for dev in devs] +1 to the proposal. Line 148: if devs_mtu: Line 149: return max(mtu, *devs_mtu) Line 150: else: Line 151: return mtu -- To view, visit http://gerrit.ovirt.org/15903 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94a58ab6a3303099105987fd230680586f6a3cce Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
