Ayal Baron has posted comments on this change.
Change subject: Remove StoragePool.getImageDomainsList().
......................................................................
Patch Set 7: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/storage/hsm.py
Line 3296: # Find out domain list from the pool metadata
Line 3297: activeDoms = sorted(pool.getDomains(activeOnly=True).keys())
Line 3298: imgDomains = []
Line 3299: for sdUUID in activeDoms:
Line 3300: with rmanager.acquireResource(STORAGE, sdUUID,
rm.LockType.shared):
this will cause operation to fail if any domain is currently locked (even
export domain) instead of ignoring the failure and continuing)
Line 3301: try:
Line 3302: dom, imgs = self.__getImages(sdUUID)
Line 3303: except se.StorageDomainDoesNotExist:
Line 3304: self.log.error("domain %s can't be reached.",
Line 3303: except se.StorageDomainDoesNotExist:
Line 3304: self.log.error("domain %s can't be reached.",
Line 3305: sdUUID, exc_info=True)
Line 3306: else:
Line 3307: if imgUUID in imgs and dom.isData():
why even try to take the shared lock on a non data domain (not to mention
calling __getImages)?
Line 3308: imgDomains.append(sdUUID)
Line 3309:
Line 3310: return dict(domainslist=imgDomains)
Line 3311:
--
To view, visit http://gerrit.ovirt.org/12927
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I225fa7a58e1fabb844cc883938e94df39d2a8ae2
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Daniel Paikov <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Elad Ben Aharon <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
