Federico Simoncelli has posted comments on this change.
Change subject: clientIF: Check disk alignment using virt-alignment-scan
......................................................................
Patch Set 13: I would prefer that you didn't submit this
(1 inline comment)
A single issue in the returning code. The rest is good. Marking with -1 for
visibility.
....................................................
File vdsm/clientIF.py
Line 368: aligning[line.partitionName] =
line.alignmentScanResult
Line 369: finally:
Line 370: self.teardownVolumePath(drive)
Line 371:
Line 372: return aligning
return {'status': doneCode, 'alignment': aligning}
Line 373:
Line 374: def createVm(self, vmParams):
Line 375: self.vmContainerLock.acquire()
Line 376: self.log.info("vmContainerLock acquired by vm %s",
--
To view, visit http://gerrit.ovirt.org/12003
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia925f5f138948acca623f6379b7b811474a43ffe
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
