Giuseppe Vallarelli has posted comments on this change. Change subject: Qos feature: Adds bandwidth definition at configuration level. ......................................................................
Patch Set 11: No score (2 inline comments) Thanks for the feedback, I'll try to add a new functional test I don't want to tweak the existing test. .................................................... File tests/netconfTests.py Line 72: else: Line 73: restoredContent = file(fn).read() Line 74: self.assertEqual(content, restoredContent) Line 75: Line 76: def assertEqualXml(self, a, b): Ok, I will do. Line 77: """ Line 78: Compare two xml strings for equality. Line 79: """ Line 80: .................................................... File vdsm/netconf/ifcfg.py Line 27: import selinux Line 28: import shutil Line 29: import threading Line 30: Line 31: Ehm nope... Line 32: from neterrors import ConfigNetworkError Line 33: import libvirtCfg Line 34: from storage.misc import execCmd Line 35: from vdsm import constants -- To view, visit http://gerrit.ovirt.org/15724 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0c3b4b9a6fd5eb53579fb2e157b5325caa88d04 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
