Dan Kenigsberg has posted comments on this change.
Change subject: vm payload: creation of full pathnames in payload
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
minor syntax comment.
....................................................
File tests/mkimageTests.py
Line 63: mkimage.DISKIMAGE_GROUP = -1
Line 64: mkimage._P_PAYLOAD_IMAGES = self.img_dir
Line 65: self.files = {}
Line 66: self.expected_results = {}
Line 67: subdir = os.path.join(*['a', 'subdirectory', 'for', 'testing'])
That's equivalent to, but more confusing than
subdir = os.path.join('a', 'subdirectory', 'for', 'testing')
Line 68: for i in range(5):
Line 69: content = os.urandom(1024)
Line 70: filename = "test_%d" % i
Line 71: longpath = os.path.join(subdir, filename)
--
To view, visit http://gerrit.ovirt.org/16072
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd76b5d9a3b79126dfcb764ac368a3631d743d1c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
