Dan Kenigsberg has posted comments on this change.
Change subject: vm payload: custom volume labels
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File tests/mkimageTests.py
Line 109: Ensures filesystem contains the desired label
Line 110: """
Line 111: if label is None:
Line 112: return
Line 113: cmd = ['blkid', '-s', 'LABEL', imgPath]
You may raise SkipTest blkid is missing. It does not deserve to be a hard
dependency.
Line 114: (ret, out, err) = storage.misc.execCmd(cmd, raw=True)
Line 115: self.assertEqual(ret, 0)
Line 116: partitions = out.rpartition('LABEL=')
Line 117: self.assertEqual(len(partitions), 3)
--
To view, visit http://gerrit.ovirt.org/14347
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5247d8f4ee01c0c871912a7998bdf958fc71ddd1
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
