Dan Kenigsberg has posted comments on this change.
Change subject: Bugfix update device hooks: after_update_device failure.
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/vm.py
Line 2989: vnicXML =
hooks.before_update_device(vnicXML.toprettyxml(
Line 2990:
encoding='utf-8'),
Line 2991: self.conf)
Line 2992: except Exception as e:
Line 2993: # A failure in the hook script execution doesn't
stop
why is this relevant? if the hook fails, the whole operation - both wiring and
changing link state - should fail.
Line 2994: # the update operation is that is still executed,
Line 2995: # the xml definition is generated by the backup
obj.
Line 2996: self.log.debug('Hook script failed',
exc_info=True)
Line 2997: vnicXML =
vnicXMLBackup.toprettyxml(encoding='utf-8')
--
To view, visit http://gerrit.ovirt.org/15982
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ab64f88e697e48ad2a3552d1361742846871ed8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
