Ayal Baron has posted comments on this change. Change subject: Reimplement hsm.getVolumesList(). ......................................................................
Patch Set 6: (3 inline comments) Once motivation is clear I'll approve the patch .................................................... Commit Message Line 3: AuthorDate: 2013-06-16 14:11:13 +0300 Line 4: Commit: Eduardo Warszawski <[email protected]> Line 5: CommitDate: 2013-06-27 11:06:04 +0300 Line 6: Line 7: Reimplement hsm.getVolumesList(). Why? And if this is the motivation then it should be listed in previous patches as well Line 8: Line 9: It is not pool dependant anymore. Line 10: Line 11: Related to BZ#960952. Line 5: CommitDate: 2013-06-27 11:06:04 +0300 Line 6: Line 7: Reimplement hsm.getVolumesList(). Line 8: Line 9: It is not pool dependant anymore. s/dependant/dependent/ Line 10: Line 11: Related to BZ#960952. Line 12: Line 13: Change-Id: Ib810ca24818fa4a77905032694a05c0d86ef75e2 Line 7: Reimplement hsm.getVolumesList(). Line 8: Line 9: It is not pool dependant anymore. Line 10: Line 11: Related to BZ#960952. related how? what is the problem you're solving? Line 12: Line 13: Change-Id: Ib810ca24818fa4a77905032694a05c0d86ef75e2 -- To view, visit http://gerrit.ovirt.org/15766 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib810ca24818fa4a77905032694a05c0d86ef75e2 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Elad Ben Aharon <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
